Add NanoAOD DQM to RelVal wfs #35412

kskovpen · 2021-09-24T19:56:35Z

PR description:

Add Nano+DQM steps to standard 2021 RelVal workflows.

PR validation:

The updated workflows were run through runTheMatrix and tested locally.

FYI @bbilin @jmartinb @rappoccio

Update

Update master branch

update master

cmsbuild · 2021-09-24T20:02:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35412/25522

This PR adds an extra 56KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Use pdigi_hi_nogen for HI MC wfs #35028
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342, Add run3 tracking low pu era #33532

cmsbuild · 2021-09-24T20:03:18Z

A new Pull Request was created by @kskovpen for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

AdrianoDee · 2021-09-24T20:09:24Z

Please test

mariadalfonso · 2021-09-24T22:25:01Z

Configuration/PyReleaseValidation/python/relval_steps.py

@@ -3504,6 +3504,15 @@ def gen2021HiMix(fragment,howMuch):
                                      '--geometry' : geom
                                      }

+    upgradeStepDict['NanoDQM'][k] = {'-s':'NANO,DQM:@nanoAODDQM',


what is the rational to define the NanoDQM here ?
I do not see the miniAODDQM

Thanks! I have updated the PR accordingly.

cmsbuild · 2021-09-25T01:25:13Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8496ea/18914/summary.html
COMMIT: f14b686
CMSSW: CMSSW_12_1_X_2021-09-24-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35412/18914/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8496ea/18914/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8496ea/18914/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 2473302
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2473274
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 149 log files, 32 edm output root files, 40 DQM output files
TriggerResults: no differences found

cmsbuild · 2021-09-25T21:34:15Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35412/25531

This PR adds an extra 56KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Use pdigi_hi_nogen for HI MC wfs #35028
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342, Add run3 tracking low pu era #33532

kskovpen · 2021-10-05T14:24:16Z

Thanks, @srimanob! The prod-like wfs now have Nano step included. Are you suggesting to add DQM to these wfs, and also run Reco+MiniAOD+Nano in one step as in baseline wfs?

Hi @kskovpen Nope. I expect the prod-like workflow run RECO, Mini, Nano separately as done in McM. No DQM is needed.

Thanks - just was confused for a moment :)

srimanob · 2021-10-05T16:21:22Z

@qliphy @perrotta Could you please consider including this to CMSSW_12_1_0_pre4. PR is almost ready. When the test result is out, I believe it should be ready to merge. It's technical PR to allow PdmV to run Nano and NanoDQM together with validation workflow.

perrotta · 2021-10-05T16:53:53Z

Urgent

@qliphy @perrotta Could you please consider including this to CMSSW_12_1_0_pre4. PR is almost ready. When the test result is out, I believe it should be ready to merge. It's technical PR to allow PdmV to run Nano and NanoDQM together with validation workflow.

@srimanob I understood from the ORP right now that this was not really that "urgent" for pre4...
In any case, if it is validated and signed by 2300, so that it can be tested in the nightly IB, we can include it

srimanob · 2021-10-05T17:05:30Z

OK, sure. No problem. I am waiting for the comparison to come. How can I remove urgent label?

cmsbuild · 2021-10-05T17:26:03Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8496ea/19413/summary.html
COMMIT: 63cafe0
CMSSW: CMSSW_12_1_X_2021-10-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35412/19413/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-8496ea/34634.21_TTbar_14TeV+2026D76_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+MiniAOD+Nano

Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 2798082
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2798054
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
Checked 159 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

qliphy · 2021-10-06T01:40:16Z

OK, sure. No problem. I am waiting for the comparison to come. How can I remove urgent label?

I have edited your comments to remove "urgent"

srimanob · 2021-10-06T03:40:54Z

+Upgrade

This PR is to add NanoAOD and NanoDQM to the standard sequence, in the same step as RECO and Mini. In addition, for the prod-like workflow, Nano step is added also after MiniAOD step.

kskovpen · 2021-10-06T06:09:02Z

+1

cmsbuild · 2021-10-06T06:09:27Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-10-08T03:01:49Z

+1

qliphy · 2021-10-09T03:38:29Z

@kskovpen This PR is causing IB issues, see #35596

srimanob · 2021-10-09T06:36:36Z

Here is the fix #35597

kskovpen added 4 commits April 17, 2021 08:55

Merge pull request #8 from cms-sw/master

7e9174b

Update

Merge pull request #9 from cms-sw/master

97857b8

Update master branch

Merge pull request #10 from cms-sw/master

da82972

update master

add relval nano wfs

f14b686

cmsbuild added this to the CMSSW_12_1_X milestone Sep 24, 2021

cmsbuild added code-checks-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Sep 24, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 24, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 24, 2021

mariadalfonso reviewed Sep 24, 2021

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Sep 25, 2021

update

a38f594

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Sep 25, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 25, 2021

cmsbuild added the urgent label Oct 5, 2021

cmsbuild added tests-approved and removed tests-started urgent labels Oct 5, 2021

cmsbuild added upgrade-approved and removed upgrade-pending labels Oct 6, 2021

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Oct 6, 2021

cmsbuild added orp-approved and removed orp-pending labels Oct 8, 2021

cmsbuild merged commit 339e2b2 into cms-sw:master Oct 8, 2021

cmsbuild mentioned this pull request Oct 8, 2021

Removed use of assertEquals in python test #35589

Merged

qliphy mentioned this pull request Oct 9, 2021

Failures in 23434.9921 and 34834.9921 workflows #35596

Closed

mariadalfonso mentioned this pull request Nov 3, 2021

Run3 production-like workflow contains duplicated NANO step since 12_1_0_pre5 #35966

Closed

kpedro88 mentioned this pull request Nov 9, 2021

Fix prodlike workflows #36050

Closed

kpedro88 mentioned this pull request Nov 18, 2021

consistent implementation of nano step for Run 3 #36167

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add NanoAOD DQM to RelVal wfs #35412

Add NanoAOD DQM to RelVal wfs #35412

kskovpen commented Sep 24, 2021

cmsbuild commented Sep 24, 2021

cmsbuild commented Sep 24, 2021

AdrianoDee commented Sep 24, 2021

mariadalfonso Sep 24, 2021

kskovpen Sep 25, 2021

cmsbuild commented Sep 25, 2021

cmsbuild commented Sep 25, 2021

kskovpen commented Oct 5, 2021

srimanob commented Oct 5, 2021 •

edited by qliphy

Loading

perrotta commented Oct 5, 2021

srimanob commented Oct 5, 2021

cmsbuild commented Oct 5, 2021

qliphy commented Oct 6, 2021

srimanob commented Oct 6, 2021

kskovpen commented Oct 6, 2021

cmsbuild commented Oct 6, 2021

qliphy commented Oct 8, 2021

qliphy commented Oct 9, 2021

srimanob commented Oct 9, 2021

Add NanoAOD DQM to RelVal wfs #35412

Add NanoAOD DQM to RelVal wfs #35412

Conversation

kskovpen commented Sep 24, 2021

PR description:

PR validation:

cmsbuild commented Sep 24, 2021

cmsbuild commented Sep 24, 2021

AdrianoDee commented Sep 24, 2021

mariadalfonso Sep 24, 2021

Choose a reason for hiding this comment

kskovpen Sep 25, 2021

Choose a reason for hiding this comment

cmsbuild commented Sep 25, 2021

Comparison Summary

cmsbuild commented Sep 25, 2021

kskovpen commented Oct 5, 2021

srimanob commented Oct 5, 2021 • edited by qliphy Loading

perrotta commented Oct 5, 2021

srimanob commented Oct 5, 2021

cmsbuild commented Oct 5, 2021

Comparison Summary

qliphy commented Oct 6, 2021

srimanob commented Oct 6, 2021

kskovpen commented Oct 6, 2021

cmsbuild commented Oct 6, 2021

qliphy commented Oct 8, 2021

qliphy commented Oct 9, 2021

srimanob commented Oct 9, 2021

srimanob commented Oct 5, 2021 •

edited by qliphy

Loading